Skip to content
This repository has been archived by the owner on Feb 1, 2023. It is now read-only.

chore: remove goprocess from blockstoremanager #572

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

guseggert
Copy link
Contributor

No description provided.

@guseggert guseggert requested a review from Jorropo August 5, 2022 14:24
@Jorropo
Copy link
Contributor

Jorropo commented Aug 5, 2022

@guseggert you know what.
Completely crazy, #570 is broken and doesn't work because it get stuck on a goprocess.
The blockstoremanager goprocess doesn't get closed.

And you remove it, sounds perfect!

(could you rebase or merge #570 into this ? else I'll do it)

@guseggert
Copy link
Contributor Author

Nice! I think it'd be easier if you did it

@guseggert guseggert force-pushed the chore/remove-process-blockstoremanager branch from 7c9bc59 to f056809 Compare August 5, 2022 14:34
@Jorropo
Copy link
Contributor

Jorropo commented Aug 5, 2022

Ok I'll pls don't merge

@guseggert
Copy link
Contributor Author

Why can't we just push this to master and then you rebase/merge from master?

@Jorropo
Copy link
Contributor

Jorropo commented Aug 5, 2022

Yeah fair. I'll merge master back.

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jorropo Jorropo merged commit 4fcd291 into master Aug 5, 2022
@Jorropo Jorropo deleted the chore/remove-process-blockstoremanager branch August 5, 2022 18:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants